Tensor validations, scope changes, and TensorPrimitives methods #103005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgsharp
requested review from
jeffhandley,
stephentoub,
eiriktsarpalis,
ericstj,
tannergooding and
luisquintanilla
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
This was referenced Jun 3, 2024
Open
src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
Show resolved
Hide resolved
| public static System.Numerics.Tensors.TensorSpan<T> AsTensorSpan<T>(this T[]? array, scoped System.ReadOnlySpan<nint> shape) { throw null; } | ||
| public static bool SequenceEqual<T>(this System.Numerics.Tensors.TensorSpan<T> span, System.Numerics.Tensors.TensorSpan<T> other) where T : System.IEquatable<T>? { throw null; } | ||
| public static System.Numerics.Tensors.TensorSpan<T> AbsInPlace<T>(System.Numerics.Tensors.TensorSpan<T> input) where T : System.IEquatable<T>, System.Numerics.IEqualityOperators<T, T, bool>, System.Numerics.INumberBase<T> { throw null; } | ||
| public static System.Numerics.Tensors.TensorSpan<T> Abs<T>(System.Numerics.Tensors.TensorSpan<T> input) where T : System.IEquatable<T>, System.Numerics.IEqualityOperators<T, T, bool>, System.Numerics.INumberBase<T> { throw null; } |
There was a problem hiding this comment.
A lot of these inputs should be ReadOnlyTensorSpan to indicate they can't be mutated. They should also be scoped to indicate the return buffer won't be capturing the underlying byref.
There was a problem hiding this comment.
I'm not going to block the PR on this happening, so we can get the improvements in.
But we do need to fix it in a follow up.
src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
Outdated
Show resolved
Hide resolved
| @@ -43,7 +41,7 @@ namespace System.Numerics.Tensors | |||
| /// <param name="array">The target array.</param> | |||
| /// <remarks>Returns default when <paramref name="array"/> is null.</remarks> | |||
| /// <exception cref="ArrayTypeMismatchException">Thrown when <paramref name="array"/> is covariant and array's type is not exactly T[].</exception> | |||
| public ReadOnlyTensorSpan(T[]? array) : this(array, 0, [], []) | |||
| public ReadOnlyTensorSpan(T[]? array) : this(array, 0, [array?.Length ?? 0], []) | |||
There was a problem hiding this comment.
nit: This is one of the cases where for perf reasons we should have a simpler implementation in the constructor body rather than deferring down to the other overload
tannergooding
approved these changes
Jun 5, 2024
michaelgsharp
force-pushed
the
tensor-validations
branch
from
55a77fd
to
fe754db
Compare
|
wasm failures are known issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a bunch of additional validations for Tensors, TensorSpans, and ReadOnlyTensorSpans to make sure they are constructed correctly and that the associated lengths/strides are correct/safe/sensible.
Adds in the changes made by the scope analysis to add in or remove
scopedas needed.Adds all but a small handful of TensorPrimitives methods for the Tensors/TensorSpans.
This PR is blocked until #102998 gets merged in.